baiyangtx commented on PR #7392:
URL: https://github.com/apache/paimon/pull/7392#issuecomment-4553338588

   
   Thanks for the review, @JingsongLi 
   
   **Cache key:** The cache stores raw `InternalRow` bytes, not deserialized 
objects. Deserialization, filtering, and conversion run fresh on every cache 
hit. `dropStats` is applied as a post-processing loop after the cache read 
returns, so the same cached bytes are safe for both `dropStats=true` and 
`dropStats=false` queries.
   
   **Correctness:** `filterByStats(entry)` executes inside 
`ManifestFile.read()` before the post-processing loop, so it always sees 
complete stats. And `dropStats` defaults to `false` — unaffected paths remain 
untouched.
   
   Fixed the PR title typo as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to