lilei1128 commented on code in PR #7969:
URL: https://github.com/apache/paimon/pull/7969#discussion_r3317859875
##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java:
##########
@@ -461,6 +463,20 @@ public void dropPartitions(Identifier identifier,
List<Map<String, String>> part
false));
} catch (NoSuchObjectException e) {
// do nothing if the partition not exists
+ } catch (MetaException e) {
+ if (ignorePartitionNonexistent
+ && !partitionExistsInHms(identifier,
partitionValues)) {
Review Comment:
I think the MetaException returned by HMS is very likely still remaining in
the HMS.
Check the processing logic of HMS:
1.ms.getPartition() → OK
2.ms.getDatabase() → NPE，MetaException
3.ms.dropPartition()
##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java:
##########
@@ -461,6 +463,20 @@ public void dropPartitions(Identifier identifier,
List<Map<String, String>> part
false));
} catch (NoSuchObjectException e) {
// do nothing if the partition not exists
+ } catch (MetaException e) {
+ if (ignorePartitionNonexistent
+ && !partitionExistsInHms(identifier,
partitionValues)) {
Review Comment:
Therefore, I suggest that when this configuration is enabled, we ignore HMS
errors, log a warning, and then delete the Paimon data.
##########
.gitignore:
##########
@@ -51,3 +50,5 @@ Cargo.lock
*libvortex_jni*
### Tantivy lib ###
*libtantivy_jni*
+
+.cursor-svg-check/
Review Comment:
remove this file from the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
