sundapeng commented on PR #8023: URL: https://github.com/apache/paimon/pull/8023#issuecomment-4566444477
+1. For object storage backends, renameBranch cannot be implemented atomically given the current branch structure, and silently doing a non-atomic rename is worse than throwing UnsupportedOperationException. Removing it from the REST surface prevents implementors from providing a broken API. Regards, Dapeng kevin ***@***.***> 于2026年5月28日周四 21:24写道： > Purpose > > Stop exposing renameBranch over the REST protocol. > RESTCatalog.renameBranch now throws UnsupportedOperationException. > > The Catalog interface and non-REST implementations ( > FileSystemBranchManager, Spark/Flink RenameBranchProcedure, etc.) are > unchanged — this PR only retires the REST surface for branch renaming. > Tests > > RESTCatalogTest#testBranches > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/paimon/pull/8023 > Commit Summary > > - 2e1a09c > <https://github.com/apache/paimon/pull/8023/commits/2e1a09c5faf9ba7a802ed09585c7a23d8c1b7384> > [rest] Remove REST renameBranch implementation > > File Changes > > (6 files <https://github.com/apache/paimon/pull/8023/files>) > > - *M* paimon-api/src/main/java/org/apache/paimon/rest/RESTApi.java > <https://github.com/apache/paimon/pull/8023/files#diff-0894e8abe766d05f831936c6f98a5f454159fcd3c9a2787f98821060b4821016> > (22) > - *M* > paimon-api/src/main/java/org/apache/paimon/rest/ResourcePaths.java > <https://github.com/apache/paimon/pull/8023/files#diff-6809e2c099bcb0ccb6b16b6f2f99d320a2a22d965739ac72082d6403e16365f5> > (13) > - *D* > paimon-api/src/main/java/org/apache/paimon/rest/requests/RenameBranchRequest.java > <https://github.com/apache/paimon/pull/8023/files#diff-24e216b41106d607bf014a8c322fbc807cc9f249e0c485daadf5bb35d78bab61> > (46) > - *M* paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java > <https://github.com/apache/paimon/pull/8023/files#diff-5e3d62d3a81b7395fc01f4658ec5dfeaa5367fd5c741b3fc08c2f5ca7c7b31d7> > (10) > - *M* > paimon-core/src/test/java/org/apache/paimon/rest/RESTCatalogServer.java > <https://github.com/apache/paimon/pull/8023/files#diff-cecb1cb6f505b5d11e34313e87a90f43af52c0a7e0c62e65748b4794b1929b63> > (27) > - *M* > paimon-core/src/test/java/org/apache/paimon/rest/RESTCatalogTest.java > <https://github.com/apache/paimon/pull/8023/files#diff-6d88a9393a91b2204b047ccdcf189816c0b59d47347e85ca442dec4e58b6786e> > (20) > > Patch Links: > > - https://github.com/apache/paimon/pull/8023.patch > - https://github.com/apache/paimon/pull/8023.diff > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/paimon/pull/8023?email_source=notifications&email_token=AA5EEEO2X2T2S56CTJ3XBEL45A4XTA5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF4ZTONRSGI2DSMJRHCTHEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVRTG633UMVZF6Y3MNFRWW>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AA5EEENQOG4EFRETFRD3AET45A4XTAVCNFSM6AAAAACZQ4HXKSVHI2DSMVQWIX3LMV43ASLTON2WKOZUGU2DANZTGYZTSNI> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
