wwj6591812 commented on PR #7991: URL: https://github.com/apache/paimon/pull/7991#issuecomment-4569367695
> LGTM from code review. > > Moving the limiter state to the operator level and checking it before `iterator.hasNext()` fixes the dedicated split path correctly: once the emitted-record limit is reached, the short-circuit prevents `RecordReaderIterator.advanceIfNeeded()` from opening more batches. The updated `OperatorSourceTest` expectation also matches the intended semantics that the limit is enforced on emitted rows, not on the input split counter. > > I tried to run the focused Flink tests locally, but this environment could not resolve the current `1.5-SNAPSHOT` artifacts (`paimon-bundle`, `paimon-service-client`, `paimon-service-runtime`), so this approval is based on code review only. Thank you very much for the review and for approving the change. Your understanding of the short-circuit before hasNext() matches what we intended. We appreciate that your approval is based on code review. We will keep an eye on CI results and share them here if anything comes up. Thanks again for your time and review. @leaves12138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
