YannByron commented on code in PR #8029:
URL: https://github.com/apache/paimon/pull/8029#discussion_r3323059793
##########
paimon-python/pypaimon/daft/daft_datasource.py:
##########
@@ -492,6 +665,14 @@ def _source_limit(
def _requires_fallback_reader(self) -> bool:
return not self._is_parquet or self._has_blob_columns or
self._table.is_primary_key_table
+ def _requires_serializable_paimon_reader_task(self) -> bool:
+ if self._warehouse_scheme in ("", "file"):
Review Comment:
In ray environment, to scan a normal append-only paimon table location on
aliyun `oss`, we expect this can run in daft native reader way. But when
`_warehouse_scheme` of this case is `oss`, this method will return true, and
`use_paimon_reader_task` will return true. This does not meet our expectations.
Correct me If i'm wrong please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
