XiaoHongbo-Hope commented on code in PR #346:
URL: https://github.com/apache/paimon-rust/pull/346#discussion_r3330462940
##########
crates/paimon/src/io/storage.rs:
##########
@@ -218,7 +331,50 @@ impl Storage {
Ok((bucket, relative_path))
}
- #[cfg(any(feature = "storage-oss", feature = "storage-s3"))]
+ #[cfg(any(
+ feature = "storage-cos",
+ feature = "storage-gcs",
+ feature = "storage-obs"
+ ))]
+ fn bucket_and_relative_path<'a>(
Review Comment:
nit: This generalized bucket_and_relative_path(storage_name,
allowed_schemes) duplicates the logic of the existing OSS/S3-specific version
above. Consider unifying into one method — OSS/S3 callers just pass their own
allowed_schemes slice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
