JingsongLi commented on code in PR #8019:
URL: https://github.com/apache/paimon/pull/8019#discussion_r3331604543
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/SparkTypeUtils.java:
##########
@@ -242,6 +251,11 @@ public DataType visit(ArrayType arrayType) {
return DataTypes.createArrayType(elementType.accept(this),
elementType.isNullable());
}
+ @Override
+ public DataType visit(VectorType vectorType) {
+ return
DataTypes.createArrayType(vectorType.getElementType().accept(this),
vectorType.isNullable());
Review Comment:
Bug: Please add tests, visit(VectorType) passes vectorType.isNullable()
(column nullability) as containsNull, but containsNull controls whether array
elements can be null. The existing visit(ArrayType) correctly passes
elementType.isNullable().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
