XiaoHongbo-Hope commented on code in PR #347:
URL: https://github.com/apache/paimon-rust/pull/347#discussion_r3334889789


##########
crates/paimon/src/table/table_commit.rs:
##########
@@ -621,6 +662,7 @@ impl TableCommit {
                     changelog_entries: changelog_entries.clone(),
                     kind,
                     index_manifest_name,
+                    index_manifest_changed: !new_index_entries.is_empty(),

Review Comment:
   Could this leave Lumina index stale after data append? If rows [10, 19] are 
appended after building
     index for [0, 9], the old index manifest is still kept and vector search 
may miss the new rows.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to