JingsongLi commented on code in PR #8031:
URL: https://github.com/apache/paimon/pull/8031#discussion_r3339782530
##########
paimon-python/setup.py:
##########
@@ -181,6 +181,9 @@ def read_requirements():
'pypaimon-rust; python_version>="3.10"',
'datafusion>=52; python_version>="3.10"',
],
+ 'hdfs': [
+ 'hdfs-native>=0.13,<1; platform_system!="Windows"',
Review Comment:
Could we add a Python version marker here? `pypaimon` still declares
`python_requires=">=3.6"` and the CI matrix covers older Python versions, but
the published `hdfs-native>=0.13` packages declare `Requires-Python: >=3.10`.
With the current extra, `pip install "pypaimon[hdfs]"` on Python 3.6-3.9 will
try to resolve this dependency and fail instead of installing `pypaimon` and
letting users keep using the legacy pyarrow backend. Something like
`hdfs-native>=0.13,<1; python_version >= "3.10" and platform_system !=
"Windows"` (plus a doc note for older Python) would avoid breaking those
environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
