JingsongLi commented on PR #8062: URL: https://github.com/apache/paimon/pull/8062#issuecomment-4601022162
Thanks for the work here. I have one concern about the SQL dialect alignment before approving. This syntax looks closer to a Snowflake-style `COPY INTO` subset than Databricks syntax. Databricks `COPY INTO` uses `FILEFORMAT = ...` plus `FORMAT_OPTIONS (...)` / `COPY_OPTIONS (...)`, and the documented copy options are things like `force` and `mergeSchema`; it does not expose `ON_ERROR = ABORT_STATEMENT | CONTINUE | SKIP_FILE` in this top-level form. If the intent is to follow Databricks syntax, I think this PR is not aligned yet. If the intent is to introduce a Snowflake-style Paimon extension, please clarify that in the PR/docs and document that this is only a subset: `ABORT_STATEMENT`, `CONTINUE`, and `SKIP_FILE` are supported, while Snowflake variants such as `SKIP_FILE_<num>` / `SKIP_FILE_<num>%` and other `COPY INTO` options are not. One more compatibility point: this changes the import result schema from 4 columns to 6 columns for all modes by adding `errors_seen` and `first_error`. Please confirm this result-schema compatibility impact is intentional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
