Stefanietry commented on code in PR #8108:
URL: https://github.com/apache/paimon/pull/8108#discussion_r3360463306
##########
paimon-core/src/main/java/org/apache/paimon/table/source/VectorSearchBuilderProvider.java:
##########
@@ -16,25 +16,15 @@
* limitations under the License.
*/
-package org.apache.paimon.spark.schema;
+package org.apache.paimon.table.source;
-import org.apache.spark.sql.connector.catalog.MetadataColumn;
+import org.apache.paimon.table.InnerTable;
-abstract class PaimonMetadataColumnBase implements MetadataColumn {
+import javax.annotation.Nullable;
- abstract boolean preserveOnDelete();
+/** SPI for engine specific {@link VectorSearchBuilder} creation. */
+public interface VectorSearchBuilderProvider {
Review Comment:
like this ? ` val vectorSearchBuilder = if
(CoreOptions.fromMap(table.options).vectorSearchDistributeEnabled()) {
new SparkVectorSearchBuilderImpl(table)
} else {
table.newVectorSearchBuilder();
}`
The previous implementation was planned to integrate the construction of
VectorSearchBuilder into
`org.apache.paimon.table.InnerTable#newVectorSearchBuilder;` If the
aforementioned custom method in PaimonBaseScan is feasible, I have completed
the modification latest version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
