QuakeWang commented on PR #8124:
URL: https://github.com/apache/paimon/pull/8124#issuecomment-4628811514

   @XiaoHongbo-Hope Thanks for catching this. You are right: 
`RayDatasink.write()` only handled close failures that propagated, while 
`DedicatedFormatWriter.close()` could abort and swallow the exception.
   
   I fixed it by re-raising after abort in `DedicatedFormatWriter.close()`, and 
applied the same fix to `DataVectorWriter.close()` since it had the same 
pattern. I also added regressions for the Ray/Dedicated path and the vector 
writer path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to