JingsongLi commented on PR #8142: URL: https://github.com/apache/paimon/pull/8142#issuecomment-4642419778
Thanks for fixing the abort cleanup path. I think this needs one more guard before merge. `readPreCommitFile` now returns `Collections.emptyList()` when a `.preCommit` file is missing, but the same `getAllPreCommitMessage(...)` path is used by both `abortJob` and successful `commitJob`. That tolerance is safe for abort cleanup, but unsafe for commit: if one task's `.preCommit` file is missing during `commitJob`, the job will commit only the remaining task messages and then delete the temp directory, which can produce a partial table commit instead of failing atomically. Could we keep the missing-file tolerance only for the abort path? For example, pass an `ignoreMissing` flag into `getAllPreCommitMessage` / `readPreCommitFile`; `abortJob` can use tolerant mode, while `commitJob` should still fail if any expected pre-commit file is absent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
