JingsongLi commented on PR #24: URL: https://github.com/apache/paimon-vector-index/pull/24#issuecomment-4660479179
Addressed the review blocker in `fvec_l2sqr`: - Replaced the `debug_assert_eq!` with a normal `assert_eq!` before dispatching into SIMD code, so the safe public API cannot enter unsafe AVX2/NEON paths with mismatched slice lengths in release builds. - Added a regression test covering mismatched lengths. Validation run: - `cargo fmt --all -- --check` - `cargo test -p paimon-vindex-core distance::tests::test_l2sqr -- --nocapture` - `cargo test -p paimon-vindex-core hnsw -- --nocapture` - `cargo clippy -p paimon-vindex-core --all-targets -- -D warnings` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
