tchivs opened a new pull request, #8208:
URL: https://github.com/apache/paimon/pull/8208
Revives #6667 and ports the JDBC catalog view support onto current `master`.
Hi @JingsongLi, I addressed the questions from the previous review in #6667:
- Added automatic initialization of the JDBC view metadata table
`paimon_views`.
It stores `(catalog_key, database_name, view_name, view_schema)` with a
primary key on the catalog/database/view tuple.
- Stored views as serialized Paimon `ViewSchema`; the JDBC catalog does not
parse or resolve the SQL text during `createView`.
- Added tests for views referencing nonexistent tables, including a
nonexistent table in another database.
- Added coverage for cross-database view rename.
- Added concurrent `createView` coverage relying on the JDBC primary key
constraint.
- Updated the implementation for the current `ViewChange` API and
`listViewDetailsPaged` fallback.
- Kept the SQLite dependency test-scoped for the Flink integration test.
Validation:
- `git diff --check`
- `mvn -pl paimon-core spotless:check`
- `mvn -pl paimon-core -am -Pfast-build -DfailIfNoTests=false
-Dtest=JdbcCatalogTest test`
- `JdbcCatalogTest` ran 62 tests, 0 failures, 0 errors.
I also attempted:
- `mvn -pl paimon-flink/paimon-flink-common -am -Pfast-build
-DfailIfNoTests=false -Dtest=JdbcCatalogViewITCase test`
That command was blocked before test execution by dependency resolution
timeout from `https://jindodata-binary.oss-cn-shanghai.aliyuncs.com/mvn-repo/`
for `com.aliyun.jindodata:jindo-core:6.9.1` and `jindo-sdk:6.9.1` while
building unrelated `paimon-jindo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
