leaves12138 commented on code in PR #8175:
URL: https://github.com/apache/paimon/pull/8175#discussion_r3394005454
##########
paimon-core/src/main/java/org/apache/paimon/operation/commit/ConflictDetection.java:
##########
@@ -670,38 +601,18 @@ Optional<RuntimeException> checkRowIdExistence(
return Optional.empty();
}
- private static class FileRowIdKey {
- private final BinaryRow partition;
- private final int bucket;
- private final long firstRowId;
- private final long rowCount;
-
- FileRowIdKey(BinaryRow partition, int bucket, long firstRowId, long
rowCount) {
- this.partition = partition;
- this.bucket = bucket;
- this.firstRowId = firstRowId;
- this.rowCount = rowCount;
- }
-
- @Override
- public boolean equals(Object o) {
- if (this == o) {
- return true;
- }
- if (o == null || getClass() != o.getClass()) {
- return false;
- }
- FileRowIdKey that = (FileRowIdKey) o;
- return bucket == that.bucket
- && firstRowId == that.firstRowId
- && rowCount == that.rowCount
- && Objects.equals(partition, that.partition);
- }
+ private static boolean rowIdRangeCovered(
Review Comment:
Can you add containsExactly to RowRangeIndex? This seems common
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
