wzx140 commented on PR #8210: URL: https://github.com/apache/paimon/pull/8210#issuecomment-4680335682
> Thanks for the patch. I think there is one behavior gap in the compatibility fallback path. > > When `alter_table_with_environmentContext(...)` is unavailable and we fall back after `NoClassDefFoundError` / `NoSuchMethodError`, `alterTableWithoutEnv(...)` still calls `client.alter_table(..., true)`. That means `alter-table-cascade=false` is ignored for those Hive runtimes, even though the PR description says the option can disable cascading schema changes. > > Would it make sense to thread the `cascade` flag through `alterTableWithoutEnv(...)` as well, so the fallback path calls `client.alter_table(..., cascade)` instead of hardcoding `true`? > > It would also be great to add a test for this branch by making `alter_table_with_environmentContext(...)` throw `NoSuchMethodError` and then verifying the fallback call uses the configured cascade value. Fixed. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
