JingsongLi commented on code in PR #8206:
URL: https://github.com/apache/paimon/pull/8206#discussion_r3401608003
##########
paimon-core/src/main/java/org/apache/paimon/table/query/LocalTableQuery.java:
##########
@@ -168,7 +168,9 @@ private void newLookupLevels(BinaryRow partition, int
bucket, List<DataFileMeta>
.getPathFile(),
lookupStoreFactory,
bfGenerator(options),
- lookupFileCache);
+ lookupFileCache,
+ // TODO pass DeletionVector factory (see reader
factory above)
Review Comment:
LocalTableQuery still passes DeletionVector. mptyFactory() to both reader
and LookupLevels, and uses PersistValueProcessor with no position information
available for new validation. Long term cache paths such as Flink lookup
service/partial lookup may still return deleted cached values even after DV
updates the same data file. The TODO here is not a small issue. The PR title
says that fixing LookupLevels respects the current DV, but this public lookup
path still completely disregards DV.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
