JingsongLi commented on PR #387: URL: https://github.com/apache/paimon-rust/pull/387#issuecomment-4714613743
Addressed the two nits from the latest review: - Removed `kanal` from paimon direct optional dependencies and the `vortex` feature. It only remains in `Cargo.lock` as a transitive Vortex dependency. - Removed the old Vortex expression conversion helpers and their unit tests, since the production read path now decodes predicate columns and applies Arrow-side filtering instead of Vortex filter pushdown. The existing Arrow-side predicate filtering tests remain in place. Local verification: - `cargo test -p paimon --features fulltext,vortex arrow::format::vortex::tests:: -- --test-threads=8 --nocapture` - `cargo test -p paimon --features fulltext,vortex table::table_write::tests::test_vortex_write_rolling_on_target_file_size -- --nocapture` - `cargo test -p paimon --all-targets --features fulltext,vortex` - `cargo clippy --all-targets --workspace --features fulltext,vortex -- -D warnings` - `cargo fmt --all -- --check` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
