JingsongLi commented on code in PR #8245:
URL: https://github.com/apache/paimon/pull/8245#discussion_r3419405155
##########
paimon-core/src/main/java/org/apache/paimon/iceberg/manifest/IcebergConversions.java:
##########
@@ -112,6 +126,12 @@ public static ByteBuffer toByteBuffer(DataType type,
Object value) {
(Timestamp) value, ((LocalZonedTimestampType)
type).getPrecision());
case TIME_WITHOUT_TIME_ZONE:
return timeToByteBuffer((Integer) value, ((TimeType)
type).getPrecision());
+ case ARRAY:
Review Comment:
This writes a Paimon-private encoding into Iceberg lower/upper bounds for
nested types. Iceberg's binary single-value serialization only has
implementations for primitive values (Iceberg `Conversions` throws for
list/map/struct), so an Iceberg reader that sees these bounds will try to
decode them as Iceberg metadata and fail or misinterpret them. If we cannot
encode these values using Iceberg's standard format, we should omit lower/upper
bounds for ARRAY/MAP/ROW instead of serializing a custom round-trip format here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
