QuakeWang commented on code in PR #391:
URL: https://github.com/apache/paimon-rust/pull/391#discussion_r3425314553
##########
crates/integrations/datafusion/tests/read_tables.rs:
##########
@@ -98,6 +99,15 @@ async fn collect_query(
ctx.sql(sql).await?.collect().await
}
+async fn assert_sql(sql: &str, expected: &[&str]) {
Review Comment:
Nit: this helper compares the full `pretty_format_batches` output verbatim.
It keeps the expected SQL result readable, but also couples the tests to
Arrow/DataFusion pretty-printer details such as padding, borders, and NULL
rendering. Fine for these small result sets; if we want less brittle tests
across dependency upgrades, comparing normalized rows/columns would be more
stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
