JingsongLi commented on PR #8270: URL: https://github.com/apache/paimon/pull/8270#issuecomment-4731225913
Addressed the review comment in `bf3b43df60`. Changes: - `apply_global_index_update_action` now checks all indexed field ids for an entry: `index_field_id` plus `extra_field_ids`. - The conflict message now reports the actual updated indexed columns, including extra fields. - Added regression coverage for updating an extra indexed column in both default error mode and `DROP_PARTITION_INDEX` mode. Verified with: - `python -m pytest pypaimon/tests/global_index_update_action_test.py -q` - `PYTHONPATH=. python -m unittest pypaimon.tests.global_index_update_action_test -v` - `python -m pytest pypaimon/tests/index_manifest_write_test.py -q` - `python -m py_compile pypaimon/write/global_index_update_checker.py pypaimon/tests/global_index_update_action_test.py pypaimon/common/options/options_utils.py pypaimon/common/options/core_options.py` - `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
