JingsongLi commented on PR #8271: URL: https://github.com/apache/paimon/pull/8271#issuecomment-4732389869
Addressed the review feedback in the latest push: - `FullTextSearchBuilder` now accepts partition filters and `FullTextScanImpl` uses them to prune full-text index files before ranking. - `HybridSearchBuilderImpl.withFilter(...)` splits pure partition predicates into `partitionFilter`; if a hybrid search contains full-text routes and still has non-partition filters, it now fails explicitly instead of returning incomplete top-K results. - Spark standalone `full_text_search` also forwards partition filters and rejects non-partition filters for the same top-K correctness reason. - Added regression coverage for hybrid full-text partition filtering and non-partition filter rejection. Verification run: - `git diff --check` - `mvn -pl paimon-core -am -Pfast-build -DfailIfNoTests=false -Dtest=FullTextSearchBuilderTest#testHybridSearchBuilderWithFullTextRoute+testHybridSearchRejectsDataFilterWithFullTextRoute,VectorSearchBuilderTest#testHybridSearchBuilderExposesRouteBuilders test` - `mvn -pl paimon-spark/paimon-spark3-common,paimon-spark/paimon-spark-ut -am -Pspark3,fast-build -DfailIfNoTests=false -DwildcardSuites=org.apache.paimon.spark.sql.HybridSearchTest -Dtest=none test` - `mvn -pl paimon-spark/paimon-spark3-common,paimon-spark/paimon-spark-ut -am -Pspark3,fast-build -DfailIfNoTests=false -DwildcardSuites=org.apache.paimon.spark.sql.FullTextSearchTest -Dtest=none test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
