JingsongLi commented on code in PR #8262:
URL: https://github.com/apache/paimon/pull/8262#discussion_r3445514200
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/source/ContinuousFileSplitEnumerator.java:
##########
@@ -328,6 +329,8 @@ protected synchronized void assignSplits() {
protected int assignSuggestedTask(FileStoreSourceSplit split) {
if (split.split() instanceof DataSplit) {
return assignSuggestedTask((DataSplit) split.split());
+ } else if (split.split() instanceof ChainSplit) {
Review Comment:
This handles `ChainSplit` for the ordinary continuous enumerator, but the
checkpoint-align source path still assumes all splits are `DataSplit`s
(`AlignedContinuousFileSplitEnumerator#addSplits` casts to `DataSplit` when
grouping by snapshot). Since chain-table streaming Phase 1 now emits
`ChainSplit`s, a query with `source.checkpoint-align.enabled=true` will fail
with `ClassCastException` before assignment. Please either add `ChainSplit`
support to the aligned enumerator/read operator path as well, or reject
checkpoint-align mode for chain-table streaming explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
