JingsongLi commented on code in PR #8236:
URL: https://github.com/apache/paimon/pull/8236#discussion_r3450879981
##########
paimon-api/src/main/java/org/apache/paimon/Snapshot.java:
##########
@@ -249,7 +302,8 @@ public Snapshot(
@JsonProperty(FIELD_WATERMARK) @Nullable Long watermark,
@JsonProperty(FIELD_STATISTICS) @Nullable String statistics,
@JsonProperty(FIELD_PROPERTIES) @Nullable Map<String, String>
properties,
- @JsonProperty(FIELD_NEXT_ROW_ID) @Nullable Long nextRowId) {
+ @JsonProperty(FIELD_NEXT_ROW_ID) @Nullable Long nextRowId,
+ @JsonProperty(FIELD_OPERATION) @Nullable Operation operation) {
Review Comment:
Thanks for restoring the no-version constructor overload. The versioned
public constructor is still source/binary incompatible because the old
`Snapshot(int version, ..., Long nextRowId)` signature was replaced by the new
one that requires `operation`. Since `Snapshot` is `@Public`, could we also
keep that old versioned overload and delegate to this constructor with
`operation = null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
