JingsongLi commented on code in PR #8280:
URL: https://github.com/apache/paimon/pull/8280#discussion_r3451147515
##########
paimon-python/pypaimon/table/source/vector_search_read.py:
##########
@@ -191,32 +218,33 @@ def read_batch(self, splits):
return [GlobalIndexResult.create_empty() for _ in range(n)]
pre_filter = self._pre_filter(splits)
Review Comment:
This PR currently conflicts with master, and this part needs a careful
rebase rather than just taking the PR-side implementation. The current master
split `read_batch` into indexed and raw paths: indexed splits are searched
through `_eval`, raw splits are still scanned via `_read_raw_search`, and the
two results are merged per query. This new native-batch path should be applied
only to the indexed splits, using the per-index-split pre-filters, then still
merge each query result with the raw fallback. Otherwise batch vector search
will either drop raw-split rows or try to treat `RawVectorSearchSplit` as an
indexed split.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
