JingsongLi commented on code in PR #8329:
URL: https://github.com/apache/paimon/pull/8329#discussion_r3459288750
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java:
##########
@@ -1164,6 +1164,9 @@ public static void
validatePkClusteringOverride(CoreOptions options) {
private static void validateManifestSort(TableSchema schema, CoreOptions
options) {
if (options.manifestSortEnabled()) {
+ if (options.dataEvolutionEnabled()) {
Review Comment:
With this early return, data-evolution tables no longer validate an
explicitly configured `manifest-sort.partition-field`, so a value that is not a
partition field (or does not exist) can pass table creation. The sorter only
ignores this option when every input manifest has RowID ranges; for partitioned
tables with any legacy/mixed manifest lacking RowID, `createSortKey` falls back
to partition sorting and throws `Cannot resolve sort field ...` during commit.
Can we keep validating the configured partition field here, and only relax the
non-partition-table requirement for the RowID-sort case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
