JingsongLi commented on code in PR #8252:
URL: https://github.com/apache/paimon/pull/8252#discussion_r3463830606
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/catalyst/plans/logical/PaimonTableValuedFunctions.scala:
##########
@@ -447,6 +592,48 @@ case class VectorSearchQuery(override val args:
Seq[Expression])
}
value.toString
}
+
+ def hasOuterReference(argsWithoutTable: Seq[Expression]): Boolean = {
+ val queryVector = argsWithoutTable(1)
Review Comment:
hasOuterReference accesses argsWithoutTable(1) before verifying the arity.
For invalid calls such as vector_search('t', 'embs'), this now throws
IndexOutOfBoundsException during resolution instead of the existing helpful
`vector_search needs three or four parameters...` error from
createVectorSearch/createDynamicVectorSearch. Please check the size before
reading the query-vector argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
