mikedias commented on code in PR #7865:
URL: https://github.com/apache/paimon/pull/7865#discussion_r3471233177
##########
paimon-core/src/main/java/org/apache/paimon/operation/AbstractFileStoreWrite.java:
##########
@@ -552,20 +552,28 @@ private RestoreFiles scanExistingFileMetas(BinaryRow
partition, int bucket) {
totalBuckets = restoredTotalBuckets;
}
if (!ignoreNumBucketCheck && totalBuckets != numBuckets) {
- String partInfo =
- partitionType.getFieldCount() > 0
- ? "partition "
- + getPartitionComputer(
- partitionType,
-
PARTITION_DEFAULT_NAME.defaultValue(),
- legacyPartitionName)
- .generatePartValues(partition)
- : "table";
- throw new RuntimeException(
- String.format(
- "Try to write %s with a new bucket num %d, but the
previous bucket num is %d. "
- + "Please switch to batch mode, and
perform INSERT OVERWRITE to rescale current data layout first.",
- partInfo, numBuckets, totalBuckets));
+ if (partitionType.getFieldCount() > 0) {
Review Comment:
Good point. Implemented the check + tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
