QuakeWang opened a new pull request, #409:
URL: https://github.com/apache/paimon-rust/pull/409
<!--
Thank you very much for contributing to Paimon Rust - we are happy that you
want to help us improve it. To help the community review your contribution in
the best possible way, please go through the checklist below, which will get
the contribution into a shape in which it can be best reviewed.
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub
issue](https://github.com/apache/paimon-rust/issues). Exceptions are made for
typos in documentation or comments, which need no issue.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `cargo test`
passes.
- Each pull request should address only one issue, not mix up code from
multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: #257
Rust aggregation schema validation allowed
`fields.<sequence-field>.aggregate-function`, but the runtime ignores that
option because sequence fields are forced to `last_value`. Java rejects this
metadata during schema validation, so Rust could create table options that are
not accepted by Java validation.
<!-- What is the purpose of the change -->
### Brief change log
<!-- Please describe the changes made in this pull request and explain how
they address the issue -->
- Reject per-field aggregate functions on `sequence.field` columns during
aggregation schema validation.
- Keep runtime sequence-field merging unchanged: sequence fields still use
`last_value` for existing or external metadata.
- Add unit and DataFusion SQL coverage for create/alter validation and
ignored primary-key functions.
- Document the sequence-field aggregation restriction.
### Tests
<!-- List unit tests or integration cases to verify this change -->
- `cargo fmt --all -- --check`
- `cargo clippy --all-targets --workspace --features
fulltext,vortex,mosaic -- -D warnings`
- `cargo test -p paimon --lib aggregation`
- `cargo test -p paimon --lib schema`
- `cargo test -p paimon-datafusion --test pk_tables aggregation`
### API and Format
<!-- Does this change affect API or storage format -->
No storage format change. This tightens validation for invalid aggregation
table options.
### Documentation
<!-- Does this change introduce a new feature or require documentation
updates -->
Updated SQL docs for sequence-field aggregation behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
