JingsongLi commented on code in PR #8355:
URL: https://github.com/apache/paimon/pull/8355#discussion_r3489515333
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java:
##########
@@ -653,6 +655,38 @@ private static void validateMapStorageLayout(TableSchema
schema, CoreOptions opt
}
options.mapSharedShreddingMaxColumns(fieldName);
}
+ if (hasSharedShredding) {
+ validateMapSharedShreddingFileFormats(options);
Review Comment:
[P1] Reject unsupported table modes for shared-shredding
This validation still accepts MAP shared-shredding for table modes that this
PR cannot write correctly. The write plan is only wired through
BaseAppendFileStoreWrite/AppendOnlyWriter; primary-key tables keep using the
normal KeyValue writer, so the option is silently ignored and files are written
as default MAP. Also, fixed-bucket append tables with the default
write-only=false use BucketedAppendCompactManager and will eventually hit
checkNoSharedShreddingRewrite after compaction.min.file-num files. Please
reject unsupported modes here, for example require append-only and either
bucket=-1 or write-only=true until rewrite support exists, or wire the
shared-shredding write plan into those paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
