wwj6591812 commented on code in PR #8117:
URL: https://github.com/apache/paimon/pull/8117#discussion_r3489829414
##########
paimon-core/src/main/java/org/apache/paimon/table/source/AbstractDataTableScan.java:
##########
@@ -97,6 +97,15 @@ protected AbstractDataTableScan(
this.options = options;
this.snapshotReader = snapshotReader;
this.queryAuth = queryAuth;
+ applyScanBucketOption();
Review Comment:
@JingsongLi Thanks for the review. I've updated the implementation as
suggested:
1、Removed the constructor-time applyScanBucketOption() from
AbstractDataTableScan.
2、Moved validation into AbstractDataTableScan.withBucket() via
validateScanBucketOption(), which checks primary-key fixed-bucket tables and
valid bucket range before applying manifest pruning.
3、Applied the scan.bucket table option in AbstractFileStoreTable.newScan() /
newStreamScan() by calling withBucket(), instead of wiring it implicitly in the
scan constructor.
4、Reverted all changes to ReadBuilderImpl — it is now identical to master.
Unit tests were moved from ReadBuilderImplTest to ScanBucketTest, and the
existing Flink ScanBucketITCase remains unchanged. Please take another look
when you have a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
