QuakeWang opened a new pull request, #421:
URL: https://github.com/apache/paimon-rust/pull/421

   <!--
   Thank you very much for contributing to Paimon Rust - we are happy that you 
want to help us improve it. To help the community review your contribution in 
the best possible way, please go through the checklist below, which will get 
the contribution into a shape in which it can be best reviewed.
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GitHub 
issue](https://github.com/apache/paimon-rust/issues). Exceptions are made for 
typos in documentation or comments, which need no issue.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
   
     - Make sure that the change passes the automated tests, i.e., `cargo test` 
passes.
   
     - Each pull request should address only one issue, not mix up code from 
multiple issues.
   
   **(The sections below can be removed for hotfixes or typos)**
   -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   
   Mosaic row selection previously expanded each selected row range into a 
`UInt64Array` of per-row indices before applying `take`. For large contiguous 
ranges, this makes memory and CPU cost proportional to the selected row count 
even though the input is already range-based.
   
   <!-- What is the purpose of the change -->
   
   ### Brief change log
   
   <!-- Please describe the changes made in this pull request and explain how 
they address the issue -->
   
     - Keep Mosaic row selections as row-group-local `(offset, len)` slices.
     - Apply a single selected range with `RecordBatch::slice`.
     - Apply multiple selected ranges with `concat_batches`.
     - Preserve row counts for empty/all-missing projections.
     - Add coverage to ensure large selections stay range-based.
   
   ### Tests
   
   <!-- List unit tests or integration cases to verify this change -->
   
     - `cargo clippy --all-targets --workspace --features 
fulltext,vortex,mosaic -- -D warnings`
     - `cargo test -p paimon --all-targets --features fulltext,vortex,mosaic 
test_mosaic`
     - `cargo test -p paimon --all-targets --features fulltext,vortex,mosaic 
arrow::format::mosaic::tests`
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature or require documentation 
updates -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to