QuakeWang commented on code in PR #422:
URL: https://github.com/apache/paimon-rust/pull/422#discussion_r3491853308
##########
crates/paimon/src/table/table_commit.rs:
##########
@@ -655,16 +1044,29 @@ impl TableCommit {
} else {
CommitKind::APPEND
};
+ let detect_conflicts = has_delete;
Review Comment:
This only enables conflict detection for direct commits when the commit
contains deletes. Data-evolution partial-column updates usually add files with
preassigned `first_row_id`/`write_cols` but no deletes, so they skip the
historical row-id/column conflict check and only validate that the original
row-id range still exists.
That misses concurrent partial updates touching the same row-id and column
range, regressing the Python `check_from_snapshot` path. Please keep an
equivalent source-snapshot marker in the commit plan/message and run
row-id/column conflict detection for these data-evolution commits, with a
concurrent same-row-id/same-column update test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
