JingsongLi commented on PR #8426: URL: https://github.com/apache/paimon/pull/8426#issuecomment-4863295092
Addressed the DV delete concurrency review comment.\n\nChanges:\n- Pass index changes into commit conflict detection.\n- Detect stale deletion-vector index commits by requiring replaced DV index files to still exist in the latest index manifest and rejecting adds that would duplicate a newer DV entry for the same data file.\n- Added a regression test for two row-level deletes prepared from the same snapshot; the stale commit now fails instead of resurrecting the earlier delete.\n\nLocal verification:\n- `python -m pytest paimon-python/pypaimon/tests/table_update_test.py -q`\n- `PYTHONPATH=paimon-python python -m pytest paimon-python/pypaimon/tests/write/conflict_detection_test.py -q`\n- `PYTHONPATH=/Users/lijingsong/IdeaProjects/paimon3/paimon-python python -m pytest paimon-python/pypaimon/tests/table_update_test.py paimon-python/pypaimon/tests/table_merge_into_test.py paimon-python/pypaimon/tests/multimodal_table_test.py paimon-python/pypaimon/tests/overwrite_changes_cache_test.p y paimon-python/pypaimon/tests/write/conflict_detection_test.py -q`\n- targeted flake8 on changed Python files\n- `git diff --check` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
