JingsongLi commented on code in PR #8447:
URL: https://github.com/apache/paimon/pull/8447#discussion_r3520066489
##########
paimon-core/src/main/java/org/apache/paimon/table/source/snapshot/SnapshotReaderImpl.java:
##########
@@ -237,7 +237,7 @@ public SnapshotReader withFilter(Predicate predicate) {
splitPartitionPredicatesAndDataPredicates(
predicate, tableSchema.logicalRowType(),
tableSchema.partitionKeys());
if (pair.getLeft().isPresent()) {
- scan.withPartitionFilter(pair.getLeft().get());
+ scan.withPartitionFilterAnd(pair.getLeft().get());
Review Comment:
Do we still need to introduce here? Since auth-derived partition predicates
are now kept in a separate slot and combined with the normal only when
computing the effective manifest filter, this PR could keep the existing
behavior for normal query filters. The repeated partition-merge semantics
feels like a separate behavior change that can be discussed independently if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
