JingsongLi commented on PR #8450: URL: https://github.com/apache/paimon/pull/8450#issuecomment-4876923572
Addressed the review comments in the latest push: - `tag` argument now uses the user-provided tag directly and does not create an additional rollback protection tag. - `snapshot_id` argument creates a dedicated non-expiring `rollback-to-as-latest-<snapshotId>-<uuid>` tag and passes that `Tag` into `TableCommitImpl`. - If rollback fails before creating the new latest snapshot, the newly-created rollback tag is deleted. If the rollback snapshot was committed and a later callback fails, the tag is kept to protect the committed snapshot files. Validation passed with the updated procedure tests, core rollback/expire tests, `git diff --check`, and the non-fast compile for core + flink-common. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
