leaves12138 commented on code in PR #8463:
URL: https://github.com/apache/paimon/pull/8463#discussion_r3524223276
##########
paimon-core/src/main/java/org/apache/paimon/table/source/FullTextReadImpl.java:
##########
@@ -225,6 +236,10 @@ private ScoredGlobalIndexResult evalQuery(
throw new IllegalArgumentException("Unsupported full-text query: " +
query);
}
+ private static boolean canPushDownWholeQuery(FullTextQuery query) {
+ return !(query instanceof FullTextQuery.MultiMatch) &&
query.columns().size() == 1;
Review Comment:
`canPushDownWholeQuery` only rejects a root `MultiMatch`. A single-column
`BooleanQuery` or `Boost` that contains a nested `MultiMatch` still has
`columns().size() == 1`, so this path pushes the whole query to
`TantivyFullTextGlobalIndexReader.toNativeQueryJson`. The new native converter
has no `MultiMatch` branch and throws `Unsupported single-column full-text
query`. Before this PR, the recursive evaluator handled `MultiMatch` by
expanding it into per-column `Match` queries. Please either reject nested
`MultiMatch` in the pushdown check or add native conversion coverage, ideally
with a regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
