JingsongLi commented on code in PR #8464:
URL: https://github.com/apache/paimon/pull/8464#discussion_r3527442056
##########
docs/docs/maintenance/metrics.md:
##########
@@ -226,6 +226,85 @@ Below is lists of Paimon built-in metrics. They are
summarized into types of sca
</tbody>
</table>
+### Blob Fetch Metrics
+
+<table class="table table-bordered">
+ <thead>
+ <tr>
+ <th class="text-left" style="width: 225pt">Metrics Name</th>
+ <th class="text-left" style="width: 70pt">Type</th>
+ <th class="text-left" style="width: 300pt">Description</th>
+ </tr>
+ </thead>
+ <tbody>
+ <tr>
+ <td>blobFetchTotal</td>
+ <td>Counter</td>
+ <td>Total number of blob fetch attempts during write, including
successful fetches, failures, and failures written as NULL.</td>
Review Comment:
Could we avoid calling this an "attempt"? `recordMissingFileNullWritten`
also increments `blobFetchTotal`, and the pre-checked missing-descriptor path
records this metric after `isNullAt` without opening the blob. Something like
"blob fetch outcomes handled during write" would match the counter semantics
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
