PyRSA commented on PR #8480:
URL: https://github.com/apache/paimon/pull/8480#issuecomment-4899899755
> This changes the non-distinct LISTAGG behavior when the accumulator is
null. For the first non-blank value, `mergeFieldSD` is initialized as
`BinaryString.EMPTY_UTF8`, and the final path returns `concat(EMPTY, delimiter,
input)`, so the result starts with the delimiter (for example `",first line"`).
This breaks the existing Flink `ListAggAggregationITCase`. Could we keep the
old `accumulator == null` handling for non-blank inputs, and add a test for
`agg(null, BinaryString.fromString("first line"))`?
Thanks for pointing this out! I've adjusted it accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
