JingsongLi commented on code in PR #8489:
URL: https://github.com/apache/paimon/pull/8489#discussion_r3534141909
##########
paimon-python/pypaimon/table/row/blob.py:
##########
@@ -391,7 +391,9 @@ def from_view(view_struct: BlobViewStruct) -> 'BlobView':
return BlobView(view_struct)
@staticmethod
- def from_bytes(data: Optional[bytes], file_io=None, allow_blob_data: bool
= True) -> Optional['Blob']:
+ def from_bytes(
+ data: Optional[bytes], file_io=None, uri_reader_factory=None,
allow_blob_data: bool = True,
Review Comment:
This inserts `uri_reader_factory` before the existing `allow_blob_data`
positional parameter, which changes the meaning of existing callers such as
`Blob.from_bytes(data, file_io, False)`. Those calls used to reject raw bytes,
but now `False` is treated as the factory and `allow_blob_data` remains `True`
(or descriptor reads can fail with `False.create(...)`). Could we keep the old
positional contract, for example `def from_bytes(data, file_io=None,
allow_blob_data=True, *, uri_reader_factory=None)`, and add a compatibility
test for the third positional argument?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
