leaves12138 commented on PR #8491:
URL: https://github.com/apache/paimon/pull/8491#issuecomment-4901604491
Thanks for the clarification. If the goal of this PR is only to improve the
diagnostics, I think this direction is reasonable.
Before merging, could we please tighten two small points so Java and
PyPaimon stay aligned and the intended non-conflict cases are covered?
1. PyPaimon consistency: `check_row_id_existence` still special-cases only
`DataFileMeta.is_blob_file(...)`. It would be better to reuse the new
`_is_dedicated_file(...)` helper there as well, so vector files follow the same
semantics as Java's `dedicatedStorageFile(...)`.
2. Positive regression coverage: the new negative test for a dedicated file
spanning multiple data-file ranges is useful. Could we also add positive cases
in both Java and Python for:
- adjacent normal data files without a dedicated bridge should not
conflict;
- a dedicated file fully covered by one normal data-file range should not
conflict.
With those covered, this looks good to merge as a diagnostics-only
improvement. This PR should not be interpreted as allowing blob/vector
compaction to span multiple normal data-file row-id ranges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
