QuakeWang opened a new pull request, #472:
URL: https://github.com/apache/paimon-rust/pull/472

   <!--
   Thank you very much for contributing to Paimon Rust - we are happy that you 
want to help us improve it. To help the community review your contribution in 
the best possible way, please go through the checklist below, which will get 
the contribution into a shape in which it can be best reviewed.
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GitHub 
issue](https://github.com/apache/paimon-rust/issues). Exceptions are made for 
typos in documentation or comments, which need no issue.
   
     - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
   
     - Make sure that the change passes the automated tests, i.e., `cargo test` 
passes.
   
     - Each pull request should address only one issue, not mix up code from 
multiple issues.
   
   **(The sections below can be removed for hotfixes or typos)**
   -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   BTree global index already supports explicit creation, but there was no 
matching drop API. Once a BTree index exists, users could not remove its index 
manifest entries through the table/DataFusion API, which also made safe rebuild 
flows awkward because create rejects overlapping existing global index ranges.
   
   <!-- What is the purpose of the change -->
   
   ### Brief change log
   
   <!-- Please describe the changes made in this pull request and explain how 
they address the issue -->
   
   - Add a BTree global index drop builder on `Table`.
   - Drop matching current-snapshot index manifest entries via 
`CommitMessage.deleted_index_files`.
   - Keep the operation idempotent: no snapshot, no index manifest, or no 
matching BTree index returns success with zero dropped entries.
   - Add `CALL sys.drop_global_index(table => '...', index_column => '...', 
index_type => 'btree')`.
   - Reject non-BTree index types and unsupported `partitions` / `dry_run` 
arguments explicitly.
   
   ### Tests
   
   <!-- List unit tests or integration cases to verify this change -->
   
   - `cargo fmt --all -- --check`
   - `cargo clippy --all-targets --workspace --features fulltext,vortex,mosaic 
-- -D warnings`
   - `cargo test -p paimon table::btree_global_index_drop_builder --lib`
   - `cargo test -p paimon-datafusion --test procedures drop_global_index`
   - `cargo test -p paimon-datafusion --test procedures create_global_index`
   - `cargo test -p paimon table::btree_global_index_build_builder --lib`
   - `cargo check -p paimon`
   - `cargo check -p paimon-datafusion`
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   Adds a Rust table API and DataFusion procedure for BTree global index drop.
   
   ### Documentation
   
   <!-- Does this change introduce a new feature or require documentation 
updates -->
   No docs update in this PR; this only exposes the narrow BTree drop lifecycle 
already represented by index manifest delete commits.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to