thswlsqls opened a new pull request, #8534:
URL: https://github.com/apache/paimon/pull/8534

   
   ### Purpose
   
   fix #8532
   
   - Generate `Float.compare(...) == 0` and `Double.compare(...) == 0` for 
floating-point `RecordEqualiser` fields.
   - Use the same floating-point comparison in nested generated scalar equality.
   - Disable raw `BinaryRow.equals()` / `BinaryArray.equals()` fast paths for 
compared type trees containing `FLOAT` or `DOUBLE`.
   - Match map keys with generated equality when the key type tree contains 
floating-point fields.
   - Keeps `NaN`, non-canonical NaN payloads, and signed-zero equality 
consistent with generated comparators after PR #8295.
   
   ### Tests
   
   - Added 
`EqualiserCodeGeneratorTest#testFloatingPointEqualiserMatchesJdkComparison` for 
`NaN`, non-canonical NaN payloads, signed zero, infinities, nested arrays, map 
keys, `GenericRow`, hybrid rows, and `BinaryRow`/`BinaryRow`.
   - `mvn -pl paimon-codegen -DwildcardSuites=none -DfailIfNoTests=false 
-Dtest=EqualiserCodeGeneratorTest#testFloatingPointEqualiserMatchesJdkComparison
 test` passed, 1 test.
   - `mvn -pl paimon-codegen -DfailIfNoTests=false clean install` passed, 225 
tests.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to