leaves12138 commented on code in PR #8562:
URL: https://github.com/apache/paimon/pull/8562#discussion_r3564417327
##########
paimon-core/src/main/java/org/apache/paimon/manifest/IndexManifestFileHandler.java:
##########
@@ -94,9 +96,15 @@ private Map<String, List<IndexManifestEntry>>
separateIndexEntries(
return result;
}
- private IndexManifestFileCombiner getIndexManifestFileCombine(String
indexType) {
+ private IndexManifestFileCombiner getIndexManifestFileCombine(
+ String indexType,
+ List<IndexManifestEntry> previousEntries,
+ List<IndexManifestEntry> currentEntries) {
+ if (hasSourceMeta(previousEntries) || hasSourceMeta(currentEntries)) {
Review Comment:
This makes `sourceMeta` an index-type-wide switch, so one source-backed
PK-vector segment disables row-range overlap validation for every ordinary
global-index entry using the same algorithm. Index manifests are grouped only
by `indexType`, and multiple field IDs can coexist in that group. I reproduced
this with a retained source-backed entry for field 1 plus a retained
range-backed entry for field 2 `[0, 99]`; adding another range-backed field-2
entry `[50, 149]` succeeds instead of throwing. Please scope the exemption to
source-backed segment comparisons rather than disabling validation for the
whole combiner, and add a mixed-entry regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
