QuakeWang commented on code in PR #496:
URL: https://github.com/apache/paimon-rust/pull/496#discussion_r3565573272
##########
crates/paimon/src/table/read_builder.rs:
##########
@@ -141,6 +147,31 @@ impl<'a> ReadBuilder<'a> {
Ok(self)
}
+ /// Set whether column-name matching (projection and predicate column
+ /// resolution) is case-sensitive. Defaults to `true` (exact match). When
set
+ /// to `false`, names are matched by ASCII case-folding and an ambiguous
+ /// (case-colliding) request errors. Mirrors Java's
Review Comment:
nit: Current Java Paimon `RowType` only exposes `getFieldIndex(String
fieldName)`; there is no `getFieldIndex(name, caseSensitive)` overload, so this
reference is inaccurate.
##########
crates/integrations/datafusion/src/table/mod.rs:
##########
@@ -426,12 +439,17 @@ impl TableProvider for PaimonTableProvider {
filters: &[&Expr],
) -> DFResult<Vec<TableProviderFilterPushDown>> {
let fields = self.table.schema().fields();
+ // SQL reads resolve columns case-sensitively (see `scan`), so classify
+ // pushdown the same way. `classify_filter_pushdown` still caps at
Review Comment:
nit: This comment is stale after `e205628c`; `classify_filter_pushdown` no
longer caps case-colliding schemas at `Inexact`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
