jerry-024 commented on PR #13: URL: https://github.com/apache/paimon-full-text/pull/13#issuecomment-4954753689
One behavioral change worth documenting: after this PR, `FullTextIndexWriter::write()` becomes single-use even if serialization fails. Previously the writer retained the source documents, so a caller could retry by writing to a fresh output after a write/flush error. Now the state is taken before commit/archive writes, so any failure leaves later `write()` calls returning `full-text index writer is already finalized`. This likely does not affect the current Paimon Java path, since `NativeFullTextGlobalIndexWriter.finish()` closes the writer after a write failure. But standalone Rust/FFI/Python callers should know this contract. Could we document that `write()` finalizes the writer regardless of success, or add a small test covering the intended single-use behavior? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
