Copilot commented on code in PR #149:
URL: https://github.com/apache/paimon-cpp/pull/149#discussion_r3569642216
##########
src/paimon/core/io/rolling_blob_file_writer.h:
##########
@@ -71,6 +71,7 @@ class RollingBlobFileWriter
void Abort() override;
Status Close() override;
Result<std::vector<std::shared_ptr<DataFileMeta>>> GetResult() override;
+ void Test() {}
Review Comment:
`Test()` adds a new public method with an empty body and no usage in the
codebase. This expands the class API for no functional reason and can confuse
callers (and may get accidentally depended on). If this was meant for unit
tests, prefer test-only access patterns (e.g., friend test, or moving the
exercised helper to a testable utility) rather than a production public method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
