thswlsqls opened a new pull request, #8627:
URL: https://github.com/apache/paimon/pull/8627
### Purpose
fix #8626
- `OrcPredicateFunctionVisitor` did not override `visitIsNaN`, so the
`FunctionVisitor.visitIsNaN` default threw `UnsupportedOperationException`.
- `OrcFileFormat.createReaderFactory()` calls `pred.visit(VISITOR)` without
a try/catch, so an `isNaN` filter (e.g. Spark `WHERE c = float('nan')`) crashed
ORC reader creation.
- Override `visitIsNaN` to return `Optional.empty()`, matching the sibling
unsupported ops
(`visitStartsWith`/`visitEndsWith`/`visitContains`/`visitLike`). ORC
SearchArgument has no isNaN leaf, so the engine evaluates the filter —
consistent with the Parquet path, where `ParquetFilters.convert` already
catches the exception and skips push-down.
### Tests
- Added `OrcFilterConverterTest#testIsNaN` asserting `isNaN` on Float/Double
fields returns `Optional.empty()` (previously threw).
- `mvn -pl paimon-format -am -DfailIfNoTests=false clean install` —
`OrcFilterConverterTest`: 21 tests passed. JDK 11, no engine profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
