JingsongLi commented on PR #509: URL: https://github.com/apache/paimon-rust/pull/509#issuecomment-4977066096
The Delta audit at `table_read.rs:243` calls `audit_raw_stream(plan, false)` and then hard-codes all rowkinds to `+I`. Even when `changelog-producer=none` is set for the PK table, Delta files still contain `_VALUE_KIND`; Java incremental audit tests explicitly require types such as `-D` to be preserved, so delete/update records are incorrectly reported as inserts. It is recommended that PK Delta also read `_VALUE_KIND` and add regression tests for DELETE/UPDATE operations. Additionally, the `rowkind` field uses the ID `-1` and `varchar(8)`, which is inconsistent with Java’s `Integer.MAX_VALUE-4` and the maximum `varchar` length; synchronization is recommended. The existing incremental/audit/exception `rowkind` tests have passed 16 out of 16, but do not cover Delta delete records. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
